search

mdbootstrap / bootstrap-hover-dropdown

An unofficial Bootstrap plugin to enable Bootstrap dropdowns to activate on hover and provide a nice user experience.
http://cameronspear.com/demos/bootstrap-hover-dropdown/
MIT License
1.26k stars 503 forks source link

Don't do anything when navbar is collapsed #136

Closed jfly closed 8 years ago

jfly commented 8 years ago

I find it very hard to use a collapsed navbar with this plugin. I think it's better to not do anything when the navbar is collapsed. I added a simple test for if the navbar is collapsed in https://github.com/jfly/bootstrap-hover-dropdown/commit/f426275df84c415435f2c22e2af3da0367bb0052. I am happy to submit a PR if interested!

CWSpear commented 8 years ago

It's normally a non-issue (since typically, people don't have the screen that small on desktop), but I think that's an alright thing to include.

jfly commented 8 years ago

Haha, for sure, people don't have screens that small, but it's not unheard of for me to make my windows that small! I've created a PR here. Entering the realm of truly crazy arguments: it's also possible to plug a mouse into your phone.

CWSpear commented 8 years ago

Our biggest issue right now are those hybrid desktop Windows machines that have touch screens. There is some promise with PointerEvents, but it has some drawbacks as well poor browser support (but all the major vendors have said they'd support it eventually).