mdbootstrap / bootstrap-toggle-buttons

Bootstrap-toggle-buttons has moved to https://github.com/nostalgiaz/bootstrap-switch
https://github.com/nostalgiaz/bootstrap-switch
Apache License 2.0
1.02k stars 92 forks source link

Re disabling a toggle button still makes it function #14

Closed Cu7l4ss closed 11 years ago

Cu7l4ss commented 11 years ago

Hi! First off I wanna say awesome work!!

To the issue: if you toggle the disabling and enabling in the example given in the github pages, after re disabling the button again, you are able to still activate the switch.

nostalgiaz commented 11 years ago

Hi! thanks @Cu7l4ss :)

To the issue: I'm not able to reproduce this bug... can you give me more informations? (e.g. the browser you're using and the version)

Cu7l4ss commented 11 years ago

Sorry for not being more comprehensive:

http://www.larentis.eu/bootstrap_toggle_buttons/ the disabled example of course

I checked on the following browsers: IE 10 Firefox 14.0.1, Chromium 23.0.1255.0 (154721), Opera 12

In all of them I'm able to reproduce the following scenario:

  1. Click the disabled button to check it is disabled ( disabled indeed)
  2. Enable the toggle button via the "toggle me!" example button
  3. Click to check it is indeed enabled (and it is)
  4. Disable the toggle button again via the "toggle me!" example button
  5. Check to see if the toggle button is indeed disabled, color is changing but it isn't disabled, clicking is still enabled

Hope this will do :)

nostalgiaz commented 11 years ago

Ok... @Cu7l4ss , can you retry please? I haven't IE10...

Cu7l4ss commented 11 years ago

Checked it out with all browsers, seems legit :) Thanks!!

nostalgiaz commented 11 years ago

You're welcome! :)