search

mdbootstrap / bootstrap-toggle-buttons

Bootstrap-toggle-buttons has moved to https://github.com/nostalgiaz/bootstrap-switch
https://github.com/nostalgiaz/bootstrap-switch
Apache License 2.0
1.02k stars 92 forks source link

Inverted background colour as the skeu suggests. #19

Closed zachinglis closed 11 years ago

zachinglis commented 11 years ago

The skeumorphism says that the slider is embossed which means counteractly behind it, it should be invertedly inset. Thus switching the colours on the gradient around (using the direction) has helped further the idea.

armisael commented 11 years ago

Isn't this more iOS-style and less Bootstrap-style? The gradient currently matches the typical style of bootstrap (take the buttons, for example) I like it...

zachinglis commented 11 years ago

Not at all.

The buttons in bootstrap are embossed, and thus lighter gradient to darker.

The reason iOS uses them with darker at the top for inset is due to the skeuomorphism. (Which toggle buttons is a very big example of.)

I like them too, and think the author did great work. But currently it's breaking the rules of skeu and giving the wrong context.

Think about it like this: When you have a light switch or a toggle switch, when it's it's raised and the other part is pressed. This is what this should reflect.

twe4ked commented 11 years ago

@zachinglis yes!

armisael commented 11 years ago

oh well, you seem quite an expert to me ;-) agree

underbluewaters commented 11 years ago

I was just thinking about making a fork and contributing a patch to do just this. Glad I saw this ticket before working on my own!

nostalgiaz commented 11 years ago

Done :)

zachinglis commented 11 years ago

Thanks! (Why did you wipe my changes and do your own though?)

nostalgiaz commented 11 years ago

Because I had Internet problem but I had already written the code :( thanks again ;)