mdbootstrap / mdb-angular-ui-kit

Angular 18 & Bootstrap 5 & Material Design UI KIT
https://mdbootstrap.com/docs/angular/
Other
1.12k stars 282 forks source link

Cannot find module '@angular/core/src/metadata/lifecycle_hooks #120

Closed amrohit closed 5 years ago

amrohit commented 5 years ago

I am using MD Boostrap with Angular 8. As soon as I ran ng server. It started throwing below error.
Note: I am not using Pro version.

ERROR in node_modules/angular-bootstrap-md/lib/navbars/links.component.d.ts(3,31): error TS2307: Cannot find module '@angular/core/src/metadata/lifecycle_hooks'. node_modules/angular-bootstrap-md/lib/navbars/navlinks.component.d.ts(3,31): error TS2307: Cannot find module '@angular/core/src/metadata/lifecycle_hooks'.

mdbootstrap commented 5 years ago

@amrohit

MDB Angular is not ready to use with Angular 8, so if it's possible, please use the Angular 7.

We'll have to upgrade our MDB Angular to be compatible with Angular 8.

kostenickj commented 5 years ago

Will angular 8 support be coming soon?

nathbailey commented 5 years ago

If you need to use the package urgently then you can modify line 2 of those files to as below and remove line 3.

import { AfterContentInit, AfterViewInit, ElementRef, QueryList, EventEmitter } from '@angular/core';

mdbootstrap commented 5 years ago

We'll take a look at this problem soon, and we'll fix it. But the full compatibility of Angular 8 won't be shipped now.

zdenekmikel commented 5 years ago

We'll take a look at this problem soon, and we'll fix it. But the full compatibility of Angular 8 won't be shipped now.

I fixed this issue and is merged, just release a new version.

tidusjar commented 5 years ago

What is the ETA for the release?

I'm hoping soon, this is currently preventing me from upgrading, and I don't really want to drop your library.

ehogiovanni commented 5 years ago

If you need to use the package urgently then you can modify line 2 of those files to as below and remove line 3.

import { AfterContentInit, AfterViewInit, ElementRef, QueryList, EventEmitter } from '@angular/core';

@nathbailey Is this line to be modified in which file? In the error file in question?

nathbailey commented 5 years ago

@thefersan the two files which require modifying are:

Remove line 3 and change line 2 to the code above

Bloodcast69 commented 5 years ago

@tidusjar Are you sure, that you have to update your project to the Angular 8 so soon? We don't want to lose you from using our library.

I'm not able to give you guys some ETA for this, but as far as I can tell, it's two to three weeks. But please, Don't take this term for granted, because a lot of things can affect him.

HarryAlvarado28 commented 5 years ago

@amrohit @nathbailey @thefersan What I did temporarily was, comment on the lines and erase the class.

Temporal

Compiled successfully

:warning: Attention, this is not the best solution. :warning:

tidusjar commented 5 years ago

@Bloodcast69 any update?

Bloodcast69 commented 5 years ago

We're getting closer. MDB Angular 8 will be shipped on the next Monday.

kathygit commented 5 years ago

Is it released ? It is Monday July 8th.

Bloodcast69 commented 5 years ago

@kathygit Yes, MDB 8 is live.