search

mdbootstrap / mdb-angular-ui-kit

Angular 18 & Bootstrap 5 & Material Design UI KIT
https://mdbootstrap.com/docs/angular/
Other
1.12k stars 282 forks source link

Fluid modal long content overflow issue #44

Closed pavillet closed 6 years ago

pavillet commented 6 years ago

Hello and thanks for the work,

From screenshot you can see header and footer are not contained in the modal in case of modal-fluid. This is from the docs capture d ecran 2018-01-15 a 16 19 37

Bloodcast69 commented 6 years ago

Hello pavillet, on which browser did you encountered this case? Could you provide me your's environment informations? I've tested this on Firefox and Chromium on Ubuntu and it's works correctly. I cannot reproduce your's case. Best Regards, Damian

pavillet commented 6 years ago

Hello,

Chrome Version 63.0.3239.132 (Build officiel) (64 bits) Mac OS 10.13

I just tested and I'm still seeing the issue on the docs

Thanks

Bloodcast69 commented 6 years ago

safari chrome

I've tested it on MacOs 10.12.6. Did you copied right code from our documentation?

pavillet commented 6 years ago

It is on your documentation so the code is the "real" one :)

Did you try reducing the window height ?

Thanks

2018-01-18 11:18 GMT+01:00 Bloodcast69 notifications@github.com:

[image: safari] https://user-images.githubusercontent.com/25751236/35092930-25f4ff32-fc41-11e7-9883-2e2af54b7fd9.png [image: chrome] https://user-images.githubusercontent.com/25751236/35092938-29064294-fc41-11e7-8975-adc9fadba8c6.png

I've tested it on MacOs 10.12.6. Did you copied right code from our documentation?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap-with-Material-Design/issues/44#issuecomment-358601942, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0ynHMxf1R3B5dV09hZaYamZXzCooXyks5tLxqEgaJpZM4RekYH .

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 adrien@wertkt.com https://wertkt.com

Bloodcast69 commented 6 years ago

Yes, i've tried to reduce window height in responsive view, and it's worked correctly. Which version of MDB and angular do you use?

pavillet commented 6 years ago
capture d ecran 2018-01-18 a 11 24 29 capture d ecran 2018-01-18 a 11 24 20

I'm on https://mdbootstrap.com/angular/advanced/modals/ so the version you use for the docs

To show you I have 2 screenshots, one will full height one where I reduce the height

2018-01-18 11:21 GMT+01:00 Bloodcast69 notifications@github.com:

Yes, i've tried to reduce window height in responsive view, and it's worked correctly. Which version of MDB and angular do you use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap-with-Material-Design/issues/44#issuecomment-358602670, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0ynEUHqj68Qy_8V1fBE9UmnHqS3MwUks5tLxsngaJpZM4RekYH .

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 adrien@wertkt.com https://wertkt.com

Bloodcast69 commented 6 years ago

Dear pavillet, it's only a bug in our documentation site. If you use this code example in your's angular project, it works fine. We'll fix that bug. Thanks for your's report. Best Regards, Damian

pavillet commented 6 years ago

Sorry if that is not clear but the bug I see is on your documentation https://mdbootstrap.com/angular/advanced/modals/

So I'm using the version you are using

2018-01-18 11:31 GMT+01:00 Bloodcast69 notifications@github.com:

Please could you specify, which version of MDB and Angular do you use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap-with-Material-Design/issues/44#issuecomment-358605484, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH .

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 adrien@wertkt.com https://wertkt.com

Bloodcast69 commented 6 years ago

Now i know what you're talking about :) We'll fix this problem with our site. Best Regards, Damian

2018-01-18 11:40 GMT+01:00 pavillet notifications@github.com:

Sorry if that is not clear but the bug I see is on your documentation https://mdbootstrap.com/angular/advanced/modals/

So I'm using the version you are using

2018-01-18 11:31 GMT+01:00 Bloodcast69 notifications@github.com:

Please could you specify, which version of MDB and Angular do you use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358605484, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap-with-Material-Design/issues/44#issuecomment-358607810, or mute the thread https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH .

pavillet commented 6 years ago

Just to be clear I checked the doc because it's an issue we had on our site ( latest mdp angular free), so this might not be only on the website

2018-01-18 11:42 GMT+01:00 Bloodcast69 notifications@github.com:

Now i know what you're talking about :) We'll fix this problem with our site. Best Regards, Damian

2018-01-18 11:40 GMT+01:00 pavillet notifications@github.com:

Sorry if that is not clear but the bug I see is on your documentation https://mdbootstrap.com/angular/advanced/modals/

So I'm using the version you are using

2018-01-18 11:31 GMT+01:00 Bloodcast69 notifications@github.com:

Please could you specify, which version of MDB and Angular do you use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358605484, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358607810, or mute the thread https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_ ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap-with-Material-Design/issues/44#issuecomment-358608172, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0ynAPpv0JlAu3au0Hzd0vn9wjr2-zPks5tLx_9gaJpZM4RekYH .

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 adrien@wertkt.com https://wertkt.com

Bloodcast69 commented 6 years ago

Did you encountered that case in your's angular project too? If yes, please specify environment.

2018-01-18 11:43 GMT+01:00 pavillet notifications@github.com:

Just to be clear I checked the doc because it's an issue we had on our site ( latest mdp angular free), so this might not be only on the website

2018-01-18 11:42 GMT+01:00 Bloodcast69 notifications@github.com:

Now i know what you're talking about :) We'll fix this problem with our site. Best Regards, Damian

2018-01-18 11:40 GMT+01:00 pavillet notifications@github.com:

Sorry if that is not clear but the bug I see is on your documentation https://mdbootstrap.com/angular/advanced/modals/

So I'm using the version you are using

2018-01-18 11:31 GMT+01:00 Bloodcast69 notifications@github.com:

Please could you specify, which version of MDB and Angular do you use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358605484, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358607810, or mute the thread https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_ ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358608172, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynAPpv0JlAu3au0Hzd0vn9wjr2-zPks5tLx_9gaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap-with-Material-Design/issues/44#issuecomment-358608492, or mute the thread https://github.com/notifications/unsubscribe-auth/AYjuxF8w7M90s3cjHfm9Deem6lNIAvfRks5tLyBPgaJpZM4RekYH .

pavillet commented 6 years ago

Same configuration with "angular-bootstrap-md": "^5.1.2",

2018-01-18 11:44 GMT+01:00 Bloodcast69 notifications@github.com:

Did you encountered that case in your's angular project too? If yes, please specify environment.

2018-01-18 11:43 GMT+01:00 pavillet notifications@github.com:

Just to be clear I checked the doc because it's an issue we had on our site ( latest mdp angular free), so this might not be only on the website

2018-01-18 11:42 GMT+01:00 Bloodcast69 notifications@github.com:

Now i know what you're talking about :) We'll fix this problem with our site. Best Regards, Damian

2018-01-18 11:40 GMT+01:00 pavillet notifications@github.com:

Sorry if that is not clear but the bug I see is on your documentation https://mdbootstrap.com/angular/advanced/modals/

So I'm using the version you are using

2018-01-18 11:31 GMT+01:00 Bloodcast69 notifications@github.com:

Please could you specify, which version of MDB and Angular do you use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358605484, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358607810, or mute the thread https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_ ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358608172, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynAPpv0JlAu3au0Hzd0vn9wjr2-zPks5tLx_9gaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358608492, or mute the thread https://github.com/notifications/unsubscribe-auth/ AYjuxF8w7M90s3cjHfm9Deem6lNIAvfRks5tLyBPgaJpZM4RekYH

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap-with-Material-Design/issues/44#issuecomment-358608808, or mute the thread https://github.com/notifications/unsubscribe-auth/AV0ynMsr8vwpBNF1ok8jh6n14JLLPPqkks5tLyCbgaJpZM4RekYH .

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 adrien@wertkt.com https://wertkt.com

Bloodcast69 commented 6 years ago

Thanks for report. I'll check this case and let you know later. Regards, Damian

2018-01-18 12:13 GMT+01:00 pavillet notifications@github.com:

Same configuration with "angular-bootstrap-md": "^5.1.2",

2018-01-18 11:44 GMT+01:00 Bloodcast69 notifications@github.com:

Did you encountered that case in your's angular project too? If yes, please specify environment.

2018-01-18 11:43 GMT+01:00 pavillet notifications@github.com:

Just to be clear I checked the doc because it's an issue we had on our site ( latest mdp angular free), so this might not be only on the website

2018-01-18 11:42 GMT+01:00 Bloodcast69 notifications@github.com:

Now i know what you're talking about :) We'll fix this problem with our site. Best Regards, Damian

2018-01-18 11:40 GMT+01:00 pavillet notifications@github.com:

Sorry if that is not clear but the bug I see is on your documentation https://mdbootstrap.com/angular/advanced/modals/

So I'm using the version you are using

2018-01-18 11:31 GMT+01:00 Bloodcast69 notifications@github.com:

Please could you specify, which version of MDB and Angular do you use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358605484, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynGVwbNgxHPWZs5ZBKcHMxlCKvY5Iks5tLx2TgaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358607810, or mute the thread https://github.com/notifications/unsubscribe-auth/AYjuxPi80Jn9X_ ruTZFb1zzcE8NnK6ySks5tLx-lgaJpZM4RekYH .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358608172, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynAPpv0JlAu3au0Hzd0vn9wjr2-zPks5tLx_9gaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358608492, or mute the thread https://github.com/notifications/unsubscribe-auth/ AYjuxF8w7M90s3cjHfm9Deem6lNIAvfRks5tLyBPgaJpZM4RekYH

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap- with-Material-Design/issues/44#issuecomment-358608808, or mute the thread https://github.com/notifications/unsubscribe-auth/ AV0ynMsr8vwpBNF1ok8jh6n14JLLPPqkks5tLyCbgaJpZM4RekYH

.

-- Adrien PAVILLETCO FONDATEUR+33 6 24 60 28 70 <+33%206%2024%2060%2028%2070> adrien@wertkt.com https://wertkt.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdbootstrap/Angular-Bootstrap-with-Material-Design/issues/44#issuecomment-358615946, or mute the thread https://github.com/notifications/unsubscribe-auth/AYjuxDM5lYKkGP834nof6mN7X81TOtS8ks5tLydIgaJpZM4RekYH .

pavillet commented 6 years ago

It seems to be fixed, closing