Move react-scripts from dependencies to devDependencies

mdbootstrap / mdb-react-ui-kit

React 18 & Bootstrap 5 & Material Design 2.0 UI KIT

https://mdbootstrap.com/docs/b5/react/

Other

1.41k stars 264 forks source link

Move react-scripts from dependencies to devDependencies #45

Closed jim-moody closed 6 years ago

jim-moody commented 6 years ago

We need to move react-scripts to devDependencies because otherwise, when users include mdbreact as a dependency and do an npm install, it also installs react-scripts which increases the node_modules size by ~300MB.

It is possible that react-scripts can be removed completely, I don't see it being used anywhere, but since there are no tests, I thought it was safer to just move for now.

Closes #44

jim-moody commented 6 years ago

Looks like this got fixed in v4.7.0 so I'll just close this PR.

https://github.com/mdbootstrap/React-Bootstrap-with-Material-Design/commit/d966fe00ebf2a648f72d0db54457bfdcf94ba981#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L30