search

mdbow22 / I-Choose-Who

An app that helps users create pokemon teams for pokemon Go based on their collection and opposing pokemon.
http://www.ichoosewho.com
GNU Affero General Public License v3.0
2 stars 2 forks source link

Bugs cause Pokollection and Recommendations not to load due to pokemon name issues when fetching image URLs #32

Open baker-ling opened 2 years ago

baker-ling commented 2 years ago

Response body: { "code": "ERR_UNESCAPED_CHARACTERS" }

baker-ling commented 2 years ago

Probably caused by "Farfetch'd"

baker-ling commented 2 years ago

Here are all the pokemon who seem like they might cause this bug in the future: image

mdbow22 commented 2 years ago

It looks like periods (.) just get removed, and spaces are converted to hyphens (-).

baker-ling commented 2 years ago

What happens to the apostrophe? Just removed like periods?

mdbow22 commented 2 years ago

Yeah, the apostrophe is just removed so farfetch'd -> farfetchd, mr. mime -> mr-mime. Hyphens are unchanged so Ho-oh and Porgyon-Z should not be an issue.

baker-ling commented 2 years ago

TODO: Add error handling to getPics. Provide a placeholder image URL when API call fails.