Grpc API change request (missing field/werid info)

mdcpp / mdoj

Mingdao OnlineJudge, A performant contest management system base on cutting edge stack.

https://mdcpp.github.io/mdoj/

4 stars 1 forks source link

Open KAIYOHUGO opened 6 days ago

KAIYOHUGO commented 6 days ago

Announcement List API provide sort by CREATE_DATE and PUBLIC

But the response didn't provide such info (CREATE_DATE and PUBLIC)

So I think we should add such info into AnnouncementInfo or remove it from sort.

Eason0729 commented 1 day ago

Adding such info would be appropriate.

Eason0729 commented 1 day ago

Can you also provide a list of similar issue(missing fields), so I could correct it in one pull request.

KAIYOHUGO commented 1 day ago

List User API have a similar issue

It provide SORT_CREATE_DATE

But response do not provide

KAIYOHUGO commented 1 day ago

List Contest API have a similar issue

It provide SORT_CREATE_DATE/SORT_UPDATE_DATE/SORT_PUBLIC

But response do not provide, we should add such field or remove it from sort.

KAIYOHUGO commented 1 day ago

The following message types has not be use. Consider remove them or provide such API

KAIYOHUGO commented 1 day ago

List Problem API have a similar issue

It provide SORT_CREATE_DATE/SORT_UPDATE_DATE/SORT_PUBLIC

But response do not provide, we should add such field or remove it from sort.

Eason0729 commented 23 hours ago

Okay, I would work on it tomorrow.(~~If lab meeting goes well~~)