search

mddub / urchin-cgm

A graph of your CGM data on a Pebble watch.
MIT License
56 stars 45 forks source link

Line between points not using "Same as next point" color choice #51

Closed Pogman closed 7 years ago

Pogman commented 7 years ago

When using the "Line color" option and setting "Same as next point" the line is always colored black and does not use the next points color.

I have a number of missed readings during the day and use the "Draw line between points" to have a continuous graph but it always has patches of black rather then colored as selected.

mddub commented 7 years ago

Thanks for reporting. Can you share a picture, and some values from /api/v1/entries.json from around the same time?

I would expect it to look like this:

testpointscolorlinewithmissingpoints-basalt https://github.com/mddub/urchin-cgm/blob/5cbe440/test/test_screenshots.py#L589-L590

Pogman commented 7 years ago

Yeah forget about the gaps and missed readings that's just how I noticed it due to having it show 4 hours of data. When I set my graph similar to that image all the lines appear black and not the next color.

Now what I noticed is that I initially went and selected a custom color and saved then when back and set it to use next color but will always use the custom color and not obey the next color option.

mddub commented 7 years ago

Can you send a screenshot of your graph settings and what you see on the watch? Thanks!

Pogman commented 7 years ago

pebcgm4 pebcgm3 pebcgm2 pebcgm1

mddub commented 7 years ago

Thanks! I see what the problem is - it's actually a bug in the Pebble Android app which I had to work around once before, then promptly forgot about. Just added the more universal fix in #53 to the latest release. Please give it a try and confirm that fixes it for you.

Pogman commented 7 years ago

Looks good - not a comprehensive test but for my 4 hour graph I see all the correct colors where there would be definite breaks before and there have been missed readings in the last hour too. Nice.

mddub commented 7 years ago

Great! Thanks for the help.