Closed phanect closed 2 months ago
This looks great! Make sure you take a look at the version-4 branch. It should be landing soon. I am happy to use GH actions.
The build process is a little more complicated. I'm happy to write a quick doc to explain how it will work in version 4.
@mde Thanks, then should this PR be merged to version-4
branch rather than main
?
The build process is a little more complicated. I'm happy to write a quick doc to explain how it will work in version 4.
OK, thanks!
@mde I opened #760 for version-4
branch.
Should this PR (to the main
branch) be closed or do you merge this PR?
This work should probably merge against main
after the version-4 branch lands. Sorry for the inconvenience.
@mde No problem, thanks!
However, the commits included in #760 are almost the same as this PR (and probably they conflict), so if you plan to merge this PR after version-4 branch is merged to main, I think this PR can be closed and #760 should be merged instead.
I'm closing this PR for now, but feel free to reopen this if I misunderstand something. Please review #760 instead 🙇🏻♂️
👍
This PR removes Travis CI and adds GitHub Actions instead. This PR is for EJS v3.x (
main
branch)I created #758 to update Node.js versions on Travis CI to the currently supported versions (v18, v20, v22), but I noticed Travis CI is not working as expected because you need to contact Travis CI support to get free credits for OSS projects. Since GitHub Actions is much more popular than Travis CI nowadays and easier to use for free, I suggest migrating to GitHub Actions.
If you prefer Travis CI, you can close this PR and consider merging #758 instead.