More improvements and testing

longlho commented 12 years ago

Couple of things:

I switched the test framework from jsUnit to Jasmine since jsUnit is no longer developed.
Added timezone arguments to toString() method to allow string output and timezone conversion on the fly. I use this a lot at work. This creates a clone of the original object which is not super efficient but I don't want to manually increment hours, date, month and year accordingly since it can be a mess.
I converted all the current test cases to Jasmine and also wrote new tests specifically for toString method.
Fix a minor bug in toString when it tries to write out AM/PM

Let me know what you think. Thanks a lot for creating this library. My team deals a lot with timezone and we used to always have to bounce back to server side to deal w/ it since Java timezone support is really good, until I found this one.

I'll do some more development and documentation on this library.

Cheers,

LH

mde commented 12 years ago

Definitely don't commit the Olson data. For the testing resources, we probably need to add a package.json that specified the dependencies. Let me know if you need some help doing that. Nice work on this.

longlho commented 12 years ago

That's a good idea. Do u plan to release this on npm? I actually do use this on the server side as well.

I'll add the package.json. Again thanks for the library :)

Long Ho Software Engineer Selerity

On May 13, 2012, at 8:25 PM, Matthew Eernissereply@reply.github.com wrote:

Definitely don't commit the Olson data. For the testing resources, we probably need to add a package.json that specified the dependencies. Let me know if you need some help doing that. Nice work on this.

Reply to this email directly or view it on GitHub: https://github.com/mde/timezone-js/pull/11#issuecomment-5680842

mde commented 12 years ago

Yes, releasing it on NPM would be a great idea. Look forward to the package.json pull-request. :)

ehimsi commented 11 years ago

I am using cometD for connectivity and face issues with '$.ajax' in date.js During runtime its value is undefined. Do we need to make some additional config changes for cometD? Please help!

Thanks. Himanshu

longlho commented 11 years ago

$.ajax is used to async load the tz data. You can replace it with your own mechanism timezoneJS.timezone.transport = someFunction

mde / timezone-js

More improvements and testing #11