search

mde / timezone-js

DEPRECATED: Timezone-enabled JavaScript Date object. Uses Olson zoneinfo files for timezone data.
824 stars 183 forks source link

`should convert timezone quickly` not a real test #136

Closed alessioalex closed 10 years ago

alessioalex commented 10 years ago

There is no expectation and no error is thrown: https://github.com/mde/timezone-js/blob/master/spec/date.spec.js#L245-L254

It doesn't really look like a test to me, but more like a benchmark.

longlho commented 10 years ago

Yeah that's correct it's purely informational. We haven't put a specific perf threshold in.

alessioalex commented 10 years ago

Shouldn't this be in a benchmark folder then, like Express does it for example: https://github.com/visionmedia/express/tree/master/benchmarks ?

2014-03-27 17:13 GMT+02:00 Long Ho notifications@github.com:

Closed #136 https://github.com/mde/timezone-js/issues/136.

Reply to this email directly or view it on GitHubhttps://github.com/mde/timezone-js/issues/136 .

longlho commented 10 years ago

Yes ideally, just that we haven't got time for it yet :( Feel free to contribute. I'm re-opening this to keep track of it.