mde / timezone-js

DEPRECATED: Timezone-enabled JavaScript Date object. Uses Olson zoneinfo files for timezone data.
824 stars 183 forks source link

fix: default format for toString method #155

Closed houqp closed 9 years ago

houqp commented 10 years ago

Otherwise Date.parse function will not be able to parse the return value of toString on firefox. This also make the behavior consistent with the comment.

houqp commented 10 years ago

Jakefile seems to be broken? I am new to Jake, so I don't know how to fix the error caused by jake.Task['npm:updateVersionFiles'].on()

mde commented 10 years ago

A Jake namespace had changed. I'm re-running this build.

mde commented 10 years ago

Looks like this does break the build. Can you take a look?

houqp commented 10 years ago

You mean the error 'TypeError: Cannot read property '1' of null' from test:init? That one is not caused by my patch since it also exists in current master branch. I have run the patch against other tests locally.

mde commented 10 years ago

Ugh, this is in master too. All right, I'll have to do some digging. :) Thanks for your patience.

houqp commented 10 years ago

I took a quick look at the error, it's caused by node-preparese.js, at line 26. For unknow reason, it's parsing the CONTRIBUTING file. I might not have enough time to look into it today. Maybe you will have a better idea of what's going on ;)

houqp commented 10 years ago

hm.. i guess the fix is to filter out none-zonefiles in _tz.zoneFiles before we go into the for loop.

mde commented 10 years ago

Yes, fixed node-preparse in master. I'm not sure how it got into this state. Can you pull fixes in, and let me know how it goes?

houqp commented 10 years ago

done, good to see the build is passing again :)

longlho commented 10 years ago

@mde I think I know why master failed. node-preparse (https://github.com/mde/timezone-js/blob/master/src/node-preparse.js#L20) has EXCLUDED pattern to not parse certain files & it seems like the tz tar recently included CONTRIBUTING which is not in that pattern. Either way you fixed it :)

houqp commented 9 years ago

@mde , bump ;)

mde commented 9 years ago

@houqp, I've made you a contributor. Feel free to merge if tests are passing!

houqp commented 9 years ago

merged, thanks!