Closed houqp closed 9 years ago
Jakefile seems to be broken? I am new to Jake, so I don't know how to fix the error caused by jake.Task['npm:updateVersionFiles'].on()
A Jake namespace had changed. I'm re-running this build.
Looks like this does break the build. Can you take a look?
You mean the error 'TypeError: Cannot read property '1' of null' from test:init
? That one is not caused by my patch since it also exists in current master branch. I have run the patch against other tests locally.
Ugh, this is in master too. All right, I'll have to do some digging. :) Thanks for your patience.
I took a quick look at the error, it's caused by node-preparese.js, at line 26. For unknow reason, it's parsing the CONTRIBUTING
file. I might not have enough time to look into it today. Maybe you will have a better idea of what's going on ;)
hm.. i guess the fix is to filter out none-zonefiles in _tz.zoneFiles
before we go into the for loop.
Yes, fixed node-preparse in master. I'm not sure how it got into this state. Can you pull fixes in, and let me know how it goes?
done, good to see the build is passing again :)
@mde I think I know why master failed. node-preparse
(https://github.com/mde/timezone-js/blob/master/src/node-preparse.js#L20) has EXCLUDED
pattern to not parse certain files & it seems like the tz tar recently included CONTRIBUTING
which is not in that pattern. Either way you fixed it :)
@mde , bump ;)
@houqp, I've made you a contributor. Feel free to merge if tests are passing!
merged, thanks!
Otherwise
Date.parse
function will not be able to parse the return value of toString on firefox. This also make the behavior consistent with the comment.