search

mde / timezone-js

DEPRECATED: Timezone-enabled JavaScript Date object. Uses Olson zoneinfo files for timezone data.
824 stars 182 forks source link

Add Travis support #27

Closed longlho closed 12 years ago

longlho commented 12 years ago

I've added .travis.yml so can we hook this project to Travis CI?

mde commented 12 years ago

Let me know if you need me to push a version to NPM.

longlho commented 12 years ago

Yup I think everything's clear. The failing unit test was a coincidence since the test use my local timezone :) Thanks for the catch. I think using a CI will avoid this kind of situation.

Feel free to push 0.4.2 to npm. :)

mde commented 12 years ago

Actually 0.4.3, pushed. :) Ah, it's a dot-file. I didn't notice the leading dot, so I wasn't seeing the file. Nice work getting it hooked up to CI.

And yes, I can remember tripping over the coincidental local-timezone-match problem before. Would be awesome if we could somehow add an explicit test for that scenario.

longlho commented 12 years ago

For the Travis CI support actually only the admin can do it so you probably will have go to travis-ci.org and flip the switch.

For the timezone match issue I can probably specify each test to run through a list of certain timezones over the world. What do you think?

mde commented 12 years ago

Had to make some tweaks so CI would run. Looks like we're green!

The accidental-match problem happens when the OS timezone happens to match the expected result in the test, right? Maybe a conditional assert that checks for either a match if the offset happens to be the same, or a thrown error if it's not?

longlho commented 12 years ago

Hmm that and also the case when developers make test cases that use the OS timezones. It my bad on my part that I used America/New_York for the failing test and didn't realize until I switched to America/Los_Angeles or Asia/Bangkok. Prob I should note down to explicitly test some timezones other than my local one?