search

mde / timezone-js

DEPRECATED: Timezone-enabled JavaScript Date object. Uses Olson zoneinfo files for timezone data.
824 stars 182 forks source link

Specifying unaltered folder from olson downloads causes errors #32

Closed stephenliberty closed 12 years ago

stephenliberty commented 12 years ago

First, excellent job with this project.

Sorry about the odd title.. hard to explain in few words. If you download the olson files right from the site, extract the entire download to a folder and then run the node_preparse.js script against it, you end up getting errors due to syntax issues. The two files that caused problems were the 'factory' file and the 'yearistype' shell script. I'm not really wanting to remember that I have to take those two files out each time that I run the script to add a timezone, so is there any way you can do sort of a 'pre-parse-check' to make sure that the file conforms to what the preparser is expecting?

ryonlife commented 12 years ago

May be addressed by the parser in my fork: https://github.com/uber/timezone-js/blob/master/timezones/build.js

Apologies for my lack of recent participation.

longlho commented 12 years ago

Sure I'll tweak the node_preparse.js