search

mde / timezone-js

DEPRECATED: Timezone-enabled JavaScript Date object. Uses Olson zoneinfo files for timezone data.
824 stars 182 forks source link

TimeZone def without time is assumed to be 23:59:59 of same date. Wrong assumption #37

Closed divide0 closed 12 years ago

divide0 commented 12 years ago

Example is Pacific/Apia, in the australasia file.

They switched from GMT-11 to GMT+13 on Dec 30 at midnight

# Dateline Change skip Friday 30th Dec 2011
# Thursday 29th December 2011   23:59:59 Hours
# Saturday 31st December 2011   00:00:00 Hours

[snip]

Zone Pacific/Apia    12:33:04 - LMT 1879 Jul  5
            -11:26:56 - LMT 1911
            -11:30  -   SAMT    1950        # Samoa Time
            -11:00  -   WST 2010 Sep 26
            -11:00  1:00    WSDT    2011 Apr 2 4:00
            -11:00  -   WST 2011 Sep 24 3:00
            -11:00  1:00    WSDT    2011 Dec 30
             13:00  1:00    WSDT    2012 Apr 1 4:00
             13:00  -   WST

Timezone-js just appends 23:59:59 if there is no time. This puts the transition at the wrong time.

longlho commented 12 years ago

I fix the setTime method and switched to '00:00:00' instead of '23:59:59'. Also added a unit test for this.