search

mde / timezone-js

DEPRECATED: Timezone-enabled JavaScript Date object. Uses Olson zoneinfo files for timezone data.
824 stars 183 forks source link

jQuery dependency not mentioned in README.md #94

Closed GabrielDelepine closed 11 years ago

GabrielDelepine commented 11 years ago

First, thanks for the team who work on timezone-js.

I'm new and I try it for the first time. I was surprise to realize timezone-js have a jQuery dependency because it's not mentioned anywhere (or I didn't found it).

It could be nice to indicate that jQuery is required in the README.md

I don't modify it and pull the request by my self because if it's not mentioned, I guess there is maybe a good reason.

longlho commented 11 years ago

Yup it's indeed missing in the documentation so feel free to submit a pull request.

longlho commented 11 years ago

Fixed in commit c57552f7442ec326dc263be77071982a12522d28

GabrielDelepine commented 11 years ago

Thanks,

Timezone-js is a great tool. I would be less cautious in the futur to make modifications by my self and pull request.