search

mde / utilities

A classic collection of JavaScript utilities
Apache License 2.0
48 stars 23 forks source link

supported inflection consistency (singular -> singular and plural -> plural) #20

Closed troyastorino closed 10 years ago

troyastorino commented 10 years ago

Geddy singularized an irregular singular noun incorrectly (Diagnosis -> Diagnosi). Added internal consistency tests for all the nouns in the test file, and made the tests pass.

troyastorino commented 10 years ago

Didn't change this, but isn't the plural of 'virus' 'viruses'? It's listed as viri in here.

mde commented 10 years ago

I'm guessing "viruses" is an exception. I can't remember because it's been years since we did the port -- is there an API exposed for adding your own exceptions?

troyastorino commented 10 years ago

It was built in as an exception. Not a big deal though. Why do you think of the PR in general? On Jun 11, 2014 8:30 PM, "Matthew Eernisse" notifications@github.com wrote:

I'm guessing "viruses" is an exception. I can't remember because it's been years since we did the port -- is there an API exposed for adding your own exceptions?

— Reply to this email directly or view it on GitHub https://github.com/mde/utilities/pull/20#issuecomment-45826664.

mde commented 10 years ago

"Viri" is specifically written in as an exception? I can't remember hearing anyone, even a doctor, use that as the plural -- not even the professor in my Immunology class back in my undergrad days. The PR looks solid.

mde commented 10 years ago

Nice work on this; thanks!

troyastorino commented 10 years ago

Cool, thanks! I'll follow up with another one switching viri to viruses then haha. I've never heard viri either On Jun 12, 2014 8:53 AM, "Matthew Eernisse" notifications@github.com wrote:

Nice work on this; thanks!

— Reply to this email directly or view it on GitHub https://github.com/mde/utilities/pull/20#issuecomment-45910326.

mde commented 10 years ago

Excellent. :)