mdedwards / slippery-chicken

slippery chicken: algorithmic composition software in common lisp and clos
http://michael-edwards.org/sc
71 stars 3 forks source link

Error after updating to SBCL 2.4.9 #102

Open rubenphilipp opened 14 hours ago

rubenphilipp commented 14 hours ago

Hello,

I was, finally, brave enough to update my SBCL from version 2.3.0 to the latest 2.4.9 (MacOS 14.7 😵‍💫). Unfortunately, I encounter the following error when running the test-suite:

PITCH: frequency: 174.614, midi-note: 53, midi-channel: 4 
       pitch-bend: 0.0 
       degree: 106, data-consistent: T, white-note: E3
       nearest-chromatic: ES3
       src: 0.66741997, src-ref-pitch: C4, score-note: ES3 
       qtr-sharp: NIL, qtr-flat: NIL, qtr-tone: NIL,  
       micro-tone: NIL, 
       sharp: NIL, flat: NIL, natural: NIL, 
       octave: 3, c5ths: 0, no-8ve: ES, no-8ve-no-acc: E
       show-accidental: T, white-degree: 30, 
       accidental: S, 
       accidental-in-parentheses: NIL, marks: NIL, 
       marks-before: NIL, amplitude: NIL
LINKED-NAMED-OBJECT: previous: NIL, 
                     this: NIL, 
                     next: NIL
NAMED-OBJECT: id: ES3, tag: NIL, 
data: ES3
**************

pitch::cmn-get-cmn-12th-tone-accidentals: what pitch was that?
   [Condition of type SIMPLE-ERROR]

Restarts:
 0: [RETRY] Retry EVAL of current toplevel form.
 1: [CONTINUE] Ignore error and continue loading file "/Users/rubenphilipp/lisp/slippery-chicken/tests/sc-test-suite.lsp".
 2: [ABORT] Abort loading file "/Users/rubenphilipp/lisp/slippery-chicken/tests/sc-test-suite.lsp".
 3: [RETRY] Retry SLY mREPL evaluation request.
 4: [*ABORT] Return to SLY's top level.
 5: [ABORT] abort thread (#<THREAD tid=5379 "sly-channel-1-mrepl-remote-1" RUNNING {7004F60DC3}>)

Backtrace:
 0: ((:METHOD GET-CMN-12TH-TONE-ACCIDENTALS (PITCH))  ..) [fast-method]
 1: ((:METHOD GET-CMN-DATA (PITCH))  ..) [fast-method]
 2: ((:METHOD GET-CMN-DATA (EVENT))  ..) [fast-method]
 3: ((:METHOD GET-CMN-DATA (RTHM-SEQ-BAR))  ..) [fast-method]
 4: ((:METHOD GET-CMN-DATA (SEQUENZ))  ..) [fast-method]
 5: ((:METHOD GET-CMN-DATA (PLAYER-SECTION))  ..) [fast-method]
 6: ((:METHOD GET-CMN-DATA (PIECE))  ..) [fast-method]
 7: ((:METHOD CMN-DISPLAY (PIECE))  ..) [fast-method]
 8: ((SB-PCL::EMF CMN-DISPLAY) #<unused argument> #<unused argument>  ..)
 9: ((:METHOD CMN-DISPLAY (SLIPPERY-CHICKEN))  ..) [fast-method]
10: ((SB-PCL::EMF CMN-DISPLAY) #<unused argument> #<unused argument>  ..)
11: (TEST-RING-MOD-PIECE)
12: ((LAMBDA NIL :IN "/Users/rubenphilipp/lisp/slippery-chicken/tests/sc-test-suite.lsp"))
13: (SB-INT:SIMPLE-EVAL-IN-LEXENV (SC-TEST-TEST-ALL) #<NULL-LEXENV>)
14: (SB-INT:SIMPLE-EVAL-IN-LEXENV (IF (SC-TEST-TEST-ALL) (PROGN (SETF *SC-TEST-METH-AND-FUNC-TESTS-STATE* "- ALL METHOD AND FUNCTION TESTS PASSED.") (FORMAT T "~%~%~a~%~%" *SC-TEST-METH-AND-FUNC-TESTS-STA..
15: (SB-EXT:EVAL-TLF (IF (SC-TEST-TEST-ALL) (PROGN (SETF *SC-TEST-METH-AND-FUNC-TESTS-STATE* "- ALL METHOD AND FUNCTION TESTS PASSED.") (FORMAT T "~%~%~a~%~%" *SC-TEST-METH-AND-FUNC-TESTS-STATE*)) (PROGN ..
16: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE) (IF (SC-TEST-TEST-ALL) (PROGN (SETF *SC-TEST-METH-AND-FUNC-TESTS-STATE* "- ALL METHOD AND FUNCTION TESTS PASSED.") (FORMAT T "~%~%~a~%~%" *SC-TES..
17: ((LAMBDA (SB-KERNEL:FORM &KEY :CURRENT-INDEX &ALLOW-OTHER-KEYS) :IN SB-INT:LOAD-AS-SOURCE) (IF (SC-TEST-TEST-ALL) (PROGN (SETF *SC-TEST-METH-AND-FUNC-TESTS-STATE* "- ALL METHOD AND FUNCTION TESTS PASS..
18: (SB-C::%DO-FORMS-FROM-INFO #<FUNCTION (LAMBDA (SB-KERNEL:FORM &KEY :CURRENT-INDEX &ALLOW-OTHER-KEYS) :IN SB-INT:LOAD-AS-SOURCE) {11389196B}> #<SB-C::SOURCE-INFO {7003810763}> SB-C::INPUT-ERROR-IN-LOAD..
19: (SB-INT:LOAD-AS-SOURCE #<SB-INT:FORM-TRACKING-STREAM for "file /Users/rubenphilipp/lisp/slippery-chicken/tests/sc-test-suite.lsp" {7003810533}> :VERBOSE NIL :PRINT NIL :CONTEXT "loading")
 --more--

This might be an easy one, but I did not find time yet to investigate. Maybe @mdedwards might already know the suspect…

Best Ruben

mdedwards commented 2 hours ago

Hallo Ruben, I’m still on sbcl 2.3.4 (MacOS 14.6.1) and brew won’t update sbcl, so I can’t check this for now. Seems strange though as 12th-tone accidentals are very old, as is that test. Maybe we’ll find a moment to look at this together. Best, Michael

rubenphilipp commented 54 minutes ago

Alright. I've quickly downgraded to SBCL 2.3.9 (couldn't easily install 2.3.4 via Homebrew) but still get the same error. Let's investigate this later maybe.

Best Ruben