search

mdedwards / slippery-chicken

slippery chicken: algorithmic composition software in common lisp and clos
http://michael-edwards.org/sc
72 stars 3 forks source link

control-wave.lsp fails to build #85

Closed rubenphilipp closed 8 months ago

rubenphilipp commented 8 months ago

Curiously I am getting an error with control-wave.lsp in my new .asd (cf. #81) that never occurred when when loading sc the "old way". It appears that sbcl is not happy with the type declaration (integer) and the initform (nil) of period. I have fixed this on a commit on the quicklisp branch (cf. https://github.com/mdedwards/slippery-chicken/commit/cd228891ce85b24e7bc20c3cbf6c4732c104a724) by removing the type definition from the period slot and adding an additional sanity check. Tests are running, though I'd appreciate further review…

control-wave.lsp:66:4:
  warning: 
    Constant NIL conflicts with its asserted type INTEGER.
    See also:
      SBCL Manual, Handling of Types [:node]

control-wave.lsp:177:1:
  style-warning: 
    IGNORE declaration for an unknown variable: IGNORE
    --> EVAL-WHEN SB-PCL::%DEFMETHOD-EXPANDER SB-PCL::LOAD-DEFMETHOD 
    --> SB-PCL::LOAD-DEFMETHOD LIST* LET* SB-INT:NAMED-LAMBDA FUNCTION 
    --> SYMBOL-MACROLET SB-PCL::FAST-LEXICAL-METHOD-FUNCTIONS 
    --> SB-PCL::BIND-FAST-LEXICAL-METHOD-FUNCTIONS FLET LET 
    --> SB-PCL::BIND-ARGS 
    ==>
      (LET* ((SB-PCL::.ARGS-TAIL. NIL) (SB-PCL::.DUMMY0.))
        (DECLARE (IGNORABLE SB-PCL::.ARGS-TAIL. SB-PCL::.DUMMY0.))
        (DECLARE (IGNORE IGNORE))
        (DECLARE
         (SB-PCL::%CLASS SLIPPERY-CHICKEN::CW SLIPPERY-CHICKEN::CONTROL-WAVE))
        (LOCALLY
         (DECLARE (DISABLE-PACKAGE-LOCKS SB-PCL::%PARAMETER-BINDING-MODIFIED))
         (SYMBOL-MACROLET ((SB-PCL::%PARAMETER-BINDING-MODIFIED #))
           (DECLARE (ENABLE-PACKAGE-LOCKS SB-PCL::%PARAMETER-BINDING-MODIFIED))
           (BLOCK SLIPPERY-CHICKEN::GET-DATA
             (LET #
               #)))))
mdedwards commented 8 months ago

Yeah, well, that's weird that the error wasn't picked up before but it's good that it's gone now. Fine with me. Closing (hope that's OK).

rubenphilipp commented 8 months ago

👍Am 16.03.2024 um 11:11 schrieb Michael Edwards @.***>: Yeah, well, that's weird that the error wasn't picked up before but it's good that it's gone now. Fine with me. Closing (hope that's OK).

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>