search

mdeering / attribute_normalizer

Adds the ability to normalize attributes cleanly with code blocks and predefined normalizers
MIT License
475 stars 53 forks source link

Default attributes? #69

Closed mauriciopasquier closed 9 years ago

mauriciopasquier commented 9 years ago

I was writing a PR (here's my branch with failing tests) about default attributes not beign applied, but then I ran into the commented-out code and this commit. I liked the idea of default attributes but if this is the direction the gem is going, at least we should fix the readme and deprecate the setter in the configuration.

mdeering commented 9 years ago

I have removed the idea of default attribute normalization and will not be restoring it as it is not a feature that I used. It is not that the idea itself is bad or anything it is that the way that it is implemented caused issues, I believe AR abstract class was one scenario but there were also others also.

I would accept a pull request with a different implementation of it in the future.

I have removed it from the README on master. Thanks for catching that.