search

mdeff / fma

FMA: A Dataset For Music Analysis
https://arxiv.org/abs/1612.01840
MIT License
2.2k stars 432 forks source link

Fix baselines.py #42

Closed JustinKavalan closed 4 years ago

JustinKavalan commented 4 years ago

This pull requests address issue #15 (which was related to corrupt files / time data mismatch) by throwing out corrupt files when being loaded.

These code changes were made on release rc1 because the current fma_metadata is out of date. I did my best to apply these changes to the most recent master, but I am unable to test if these changes are working correctly (hence, why baselines.py currently uses generateData instead of the same changes made in utils.py).

Any help in testing master and code revisions/suggestions are appreciated.

mdeff commented 4 years ago

Thanks for the PR! It was a poor decision of mine to mix up the code for the creation of an hypothetical next release and the maintenance of the usage code and doc for the latest released version. I've now corrected this mistake and made two branches: master works with the latest released data (i.e., rc1) and next contains code to prepare a next release. More at #41.

I've tried to rebase your modifications on top of master but made a wrong manipulation that closed the PR and removed my right to edit. :/

Can you reopen it, and base your changes on the current master? It should then work with the publicly available rc1 data. :)