search

mdegans / tegrity

Helps bake Tegra system images
MIT License
19 stars 2 forks source link

CVE-2007-4559 Patch #4

Closed TrellixVulnTeam closed 1 year ago

TrellixVulnTeam commented 1 year ago

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

mdegans commented 1 year ago

Ok. LGTM. Thanks. Sorry for not merging this earlier. I was on vacation at that time and likely missed it reviewing emails when I got back. Thanks for the additional info. I knew about the class of attack but would have thought extract_all would have handled that, this being Python, but I was wrong. I guess it makes sense since it's allowed for archives to do that, but it's probably not a good idea here :) I will reach out if I have any questions.