search

mdegat01 / addon-promtail

Promtail for Home Assistant
MIT License
15 stars 18 forks source link

Update nodename label to hostname #218

Closed mateuszdrab closed 1 year ago

mateuszdrab commented 1 year ago

Hey

I've been wondering if it would not be a better idea to relabel __journal__hostname into hostname rather than nodename which seems more specific to the Kubernetes node concept.

Would you agree?

mdegat01 commented 1 year ago

That's fair. I'm not sure where nodename came from tbh, I must've copied it from an example. That being said, this is a breaking change. Can put that value in both the nodename and hostname labels going forward to keep it backwards compatible?

mateuszdrab commented 1 year ago

That's fair. I'm not sure where nodename came from tbh, I must've copied it from an example. That being said, this is a breaking change. Can put that value in both the nodename and hostname labels going forward to keep it backwards compatible?

I was thinking it would be a breaking change so maybe instead you could add extraRelabelConfigs as a config parameter? I know you can overwrite the default job config but that requires providing a path to a file. I was hoping to add a relabel statement into the config area of the add on or even provide the entire yaml into additionalScrapeConfigs rather than a file.

What are your thoughts?

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.