mdehoog / Semantic-UI-Calendar

Calendar module for Semantic UI
MIT License
805 stars 126 forks source link

click binding on mobile #46

Closed littlegreenguy closed 7 years ago

littlegreenguy commented 7 years ago

Hi! this is working great on desktop, but when i'm on my iPhone 6s, the popup only appears if I click on the LABEL rather than the INPUT. Is there any way to bind the click specifically to the input?

I tried adding: selector: { popup: '.ui.popup', input: 'input', activator: 'input' }, But it didn't help.

this is my markup:

<div class="field">
    <label for="invoice_date"> Invoice Date </label>
    <div class="ui calendar" id="date-picker">
        <input id="invoice_date" name="invoice_date" type="text" value="Feb 13 2017">
        </input>
    </div>
</div>
   $('#date-picker').calendar({
    type: 'date'
  });
mdehoog commented 7 years ago

The click handling works on iPhone for me, do the jsbin examples work? https://jsbin.com/ruqakehefa/

littlegreenguy commented 7 years ago

yes they do actually - sorry, must just be my code! great extension anyway, and thanks for getting back to me!

Nick

On 5 Mar 2017, at 23:23, Michael de Hoog notifications@github.com wrote:

The click handling works on iPhone for me, do the jsbin examples work? https://jsbin.com/ruqakehefa/ https://jsbin.com/ruqakehefa/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdehoog/Semantic-UI-Calendar/issues/46#issuecomment-284272308, or mute the thread https://github.com/notifications/unsubscribe-auth/AFcWw5u3T2QU2i4XNdtmM7wzrUJjXcy4ks5ri0P0gaJpZM4L_Rdk.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mdehoog/Semantic-UI-Calendar","title":"mdehoog/Semantic-UI-Calendar","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mdehoog/Semantic-UI-Calendar"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mdehoog in #46: The click handling works on iPhone for me, do the jsbin examples work? https://jsbin.com/ruqakehefa/"}],"action":{"name":"View Issue","url":"https://github.com/mdehoog/Semantic-UI-Calendar/issues/46#issuecomment-284272308"}}}