search

mdekauwe / GDAY

GDAY simulates carbon, nitrogen & water dynamics
16 stars 31 forks source link

LUE component #13

Closed Jinyan-Yang closed 5 years ago

Jinyan-Yang commented 5 years ago

Target: Develop a model that has grass phenology and species competition

Issues: I can't get the LUE component to produce a reasonable value.

Not sure what I did wrong but here's something I found:

  1. The met file from the example folder did not have the columns in the same order as the model assumes to read in. This is because the model reads each column in a fix order (hardwired) without checking the column names. I change the columns in the met file for now but will try to change the code to check the column names;
  2. The f->apar in L542 in photosynthesis is timed by 60.0 60.0 daylen; which assmues the apar is mumol m-2 s-1 but the apar should have the same unit asm->par which is mj m-2 d-1;
  3. I'm still don't have a solution yet but will update as it moves on.
  4. Realted to 2. PAR is defined as the sum of par_am and par_pm from met data: m->par = ma->par_am[c->day_idx] + ma->par_pm[c->dayidx]. par in the met data should be in mumol m-2 s-1. This makes the sum of the two not informative?
  5. I think based on the code, that the readme file listed wrong units. par_am and pm should be mj m-2 halfday-1.

Small unrealted things:

  1. Small typo in water_balace.c: "top_soil_loss" should be "topsoil_loss"?
  2. In read_metdata.c, "current_yr" did not has a initial value;

Windoes freindly changes:

  1. I silenced all the git related bits since it doesn't provide any use for now;
  2. The parameter and met data files are not fixed to be par.cfg and met.csv which should be in the same folder as the exe.