search

mdelobelle / metadatamenu

For data management enthusiasts : type and manage the metadata of your notes.
https://mdelobelle.github.io/metadatamenu
MIT License
478 stars 27 forks source link

Fileclass Settings won't save after recent insider update #578

Closed dml0sc closed 4 months ago

dml0sc commented 4 months ago

It seems that after the recent insider update, Fileclass Settings are not responsive. I am experiencing issues with the Button Icon (which will not change and after saving goes back to default) and parent file classes which I can select but are not acknowledged. In the Release Note of the 1.5.5 Obsidian insider update, I read: 'File Explorer and Tags pane both received a small code refactor. This might affect some plugins that rely on the internal JS structure'. Could that cause the problem?

mdelobelle commented 4 months ago

Do you have any error in the console?

Could you test with 0.8.0-beta-4 please? Do you still encounter this issue? https://github.com/mdelobelle/metadatamenu/releases/tag/0.8.0-beta-4

Felharrim commented 4 months ago

I faced the same problem. Icons assigned to properties in a class are not displayed. Everything works by default. I also checked it with the beta version. All the same.

mdelobelle commented 4 months ago

I can't reproduce this issue. Could you paste some screen shots of what is happening? (and any error console that may be printed when you try to change an icon?)

Felharrim commented 4 months ago

Setting Class properties image view window setting image or from context menu image

mdelobelle commented 4 months ago

This is not a bug. Unlike the icon for the fileclass button, the icons for field actions (that you have underlined in your screenshots) have always been fixed and cannot be customized. The icon name in the field setting form is only used to identify the field's command (from the command palette "Metadata Menu: insert field") in the mobile app's toolbar

Felharrim commented 4 months ago

Thank you! This helped clarify the point. But why is there no information about this in the interface itself? (for example - Icon settings for the mobile version)

mdelobelle commented 4 months ago

fair point. I'll improve that in the next version

mdelobelle commented 4 months ago

CHanged in 0.8.1