search

mdelobelle / obsidian_supercharged_links

obsidian plugin to add attributes and context menu options to internal links
MIT License
537 stars 35 forks source link

[Enhancement] Option to specify mode to use [light, dark] #149

Open danieltomasz opened 2 years ago

danieltomasz commented 2 years ago

Would be great to have an option to specify the mode when the css is applied, Currently I use great pastel colors, it looks great with dark mode, but the titles are illegible when in the light mode

Solution would be to have optional setting to specify the condition when the formatting is applied (light, dark, both)

HEmile commented 2 years ago

You can achieve this with CSS for sure. Do you mean in the generator? I think that could be a good idea.

danieltomasz commented 2 years ago

Yes, I mean in the generator :) I am thinking how this might be solved from UI/UX point of view, to not burden user :)

Maybe in the the "Edit selector" field adding toggle "different styles for light/dark theme" will cause adding option for colors for light and dark mode in "Style Settings" for this specific tag

this is not crucial but nice to have feature for completness

HEmile commented 2 years ago

Yes, I like the idea! I'll add it when I next iterate the plugin.