-tags broken by go/packages transition

mdempsky / unconvert

Remove unnecessary type conversions from Go source

BSD 3-Clause "New" or "Revised" License

377 stars 26 forks source link

-tags broken by go/packages transition #37

Closed mdempsky closed 5 years ago

mdempsky commented 5 years ago

It looks like the -tags flag is broken since switching to go/packages. Looking at the go/packages API, it's not immediately clear to me how to implement this functionality.

Intuitively, I'd assume I just pass through "-tags=foo bar" in go/packages's Config.BuildFlags, but it's not clear to me what flags the "build system query tool" supports.

@egonelbre

dominikh commented 5 years ago

The general consensus is to construct said -tags flag and pass it via BuildFlags, under the assumption that all build systems will support the flag.

mdempsky commented 5 years ago

Thanks @dominikh!