search

mdempsky / unconvert

Remove unnecessary type conversions from Go source
BSD 3-Clause "New" or "Revised" License
377 stars 26 forks source link

Exit with non-zero code if we reported conversions #6

Closed dominikh closed 8 years ago

dominikh commented 8 years ago

Closes gh-5

dominikh commented 8 years ago

@mdempsky Do you want me revise the PR, or is it easier for you to just write it yourself at this point?

dominikh commented 8 years ago

Updated the PR.

mdempsky commented 8 years ago

Easier if all I have to do is a click a button. :)

Gross that it ended up as a merge commit, rather than a fast forward. Is that fundamental to GitHub PRs, or can I avoid that somehow? (I'm more used to Gerrit.)

dominikh commented 8 years ago

It is fundamental of GitHub PRs. The merge button always creates a merge commit.

mdempsky commented 8 years ago

That sucks. Oh well.

Thanks!

dmitshur commented 8 years ago

The merge button always creates a merge commit.

That sucks. Oh well.

For posterity, this has since changed. It used to be true for many years, but it's no longer true as of a few months ago. GitHub now has a "squash" merge mode that rebases and squashes into a single commit when merging.

See https://github.com/blog/2141-squash-your-commits.

mdempsky commented 8 years ago

Yep, I've started using that!