search

mdenet / educationplatform-docker

Dockerized version of the education platform
Eclipse Public License 2.0
0 stars 1 forks source link

Fixes for 64 running the platform not working on windows 10 #11

Closed barnettwilliam closed 1 year ago

barnettwilliam commented 1 year ago

mdenet/educationplatform#64, adding gitattributes to all repositories so future commits are normalised properly across all platforms developers are using.

Updated the readme to include preconfiguration steps for windows and updated the submodules to also include the added gitattributes file.

Note - the github diff of this pull request's submodules shows changes that were previously made in addition to the actual changes. I'm not sure why this is. I did rebase some of the submodule branches to incorporate changes from merged into main to keep the working bracnh up to date. The diffs of the individual submodules pull request show the correct changes.

barnettwilliam commented 1 year ago

@arturboronat this pull request contains the fixes for running the platform on windows. Please can you try it out and see if it works for you by deleting your old educationplatform-docker directory and using

git pull clone --recurse-submodules  https://github.com/mdenet/educationplatform-docker.git -b 64-running-the-platform-not-working-on-windows-10
barnettwilliam commented 1 year ago

Generally LGTM. I notice that there are quite a lot of updates in the sub-modules. Is it possible that that's because these are referring to a wrong (possibly older?) SHA? Or are all these changes really needed to make things work in Windows?

Fewer changes have been made compared to what is reported by the diff. I checked the submodule SHAs and they are correct in the commit. Its the SHA of educationplatform-docker's base submodule branch that's being used to diff against that is outdated and also showing older changes.

arturboronat commented 1 year ago

Hi @barnettwilliam @szschaler, It worked like a charm. Many thanks!