search

mdenet / educationplatform

Eclipse Public License 2.0
2 stars 3 forks source link

Tests for ActivityValidator #190

Closed barnettwilliam closed 3 months ago

barnettwilliam commented 4 months ago

Unit tests for the ActivityValidator and minor modification to export error constants so they could be used in the tests.

Note https://github.com/mdenet/educationplatform/pull/189 should be merged first

I considered loading configuration files rather than reconstructing minimal test activity and tool objects that was done in these tests but it meant relying on the ActivityManager and ToolManager and become too much of an integration test.

Code coverage for the module is 100%

szschaler commented 4 months ago

@barnettwilliam, can you please ping me when #189 has been merged and this has been rebased so I can more easily see the bits that actually need reviewing?

barnettwilliam commented 4 months ago

Yes will do

barnettwilliam commented 4 months ago

@szschaler now rebased and ready for review