search

mdenet / educationplatform

Eclipse Public License 2.0
2 stars 3 forks source link

Windows globals should not be used #196

Open barnettwilliam opened 4 months ago

barnettwilliam commented 4 months ago

Windows globals have the potential to clash and inadvertently modified instead they should be removed and registered by EducationPlatform or at least be namespaced to reduce the likelihood of problems https://github.com/mdenet/educationplatform/pull/194#discussion_r1524509787.

https://github.com/mdenet/educationplatform/blob/75016a474fb4937fa4fe6d3a9c4a346c3f931213/platform/src/index.js#L11-L23