mdenet / educationplatform

Eclipse Public License 2.0
2 stars 3 forks source link

Remove parameterName parameter from convert #58

Open barnettwilliam opened 1 year ago

barnettwilliam commented 1 year ago

Remove the parameter name from convert() and convertIncludingMetamodel().

The parameterName is added to the class returned by the promise of the convert function for the converted value. So when all of the action function's parameters resolve and the action function is ready to be invoked, the converted values can be mapped to respective parameter names for creating the request.

It is possible to refactor to remove parameterName because Promise.all preserves the order in which the promises are added so the resolved values match the parameter order the invokeActionFunction() creates. However, this requires #41 to be fixed otherwise when building the request additional optional parameters are inserted that won't match invokeActionFunction() parameter order exactly as is needed.

_Originally posted by @barnettwilliam in https://github.com/mdenet/educationplatform/pull/49#discussion_r1190452451_