search

mdenet / platformtools

Education platform tool functions.
Eclipse Public License 2.0
0 stars 3 forks source link

Fix xtext project files incorrectly created #56

Closed barnettwilliam closed 6 months ago

barnettwilliam commented 8 months ago

Fixes #55, only the language name is used to derive the project paths. This makes baseName independent which is used for the eclipse project and containing folder name only, this is the same as the Eclipse Xtext project wizard.

This is a breaking change and requires the fix in PR mdenet/educationplatform-examples#9 to be applied to all activities that are based off-of the Xtext example.

barnettwilliam commented 8 months ago

After testing with a different Xtext project created for activity 'using outputs of Xtext' it was also required make the paths independent of baseName in addition to what was suggested here https://github.com/mdenet/platformtools/issues/55#issuecomment-1935980134

szschaler commented 8 months ago

While this is ready to merge in principle (pending full review), we will hold off until April to avoid breaking existing teaching activities currently being used in teaching at KCL.