search

mderrick / react-html5video

A customizeable HTML5 Video React component with i18n and a11y.
http://mderrick.github.io/react-html5video/
MIT License
459 stars 123 forks source link

Fullscreen does not show custom control bar #72

Closed dennyferra closed 7 years ago

dennyferra commented 7 years ago

The custom control bar does not appear in fullscreen.

I believe this would be a fairly trivial fix. In order to get the control bar to appear in full screen you just need to call requestFullScreen on the container instead of the video element.

For example in https://github.com/mderrick/react-html5video/blob/master/src/components/video/Video.js#L155 you could use videoEl.parentElement to accomplish this.

I can submit a pull request for this.

mderrick commented 7 years ago

Thanks for the issue, this indeed is a nice feature. I'm currently working on a v2 branch and have implemented it there.

I wasn't planning on adding new features to v1 anymore. Do you require this in v1?

dennyferra commented 7 years ago

@mderrick Awesome! I have no need to update v1 I actually had to customize the fullscreen code to do some additional things so I have my own fullscreen implementation. Looking forward to v2, thanks!