search

mderrick / react-html5video

A customizeable HTML5 Video React component with i18n and a11y.
http://mderrick.github.io/react-html5video/
MIT License
459 stars 123 forks source link

#77 Close fullscreen using the control fix #81

Closed mderrick closed 7 years ago

mderrick commented 7 years ago

Inspired by #78 fixing bug #77 but with added tests.

Bram-Zijp commented 7 years ago

I have 2.0.0 but the fullscreen button still only enters fullscreen. Going out doesn't work.

mderrick commented 7 years ago

@Bram-Zijp I hadn't deployed it as I was going to bundle in a another fix before deploying. I just released v2.0.1. It's being published as we speak. Let me know if it works.

https://travis-ci.org/mderrick/react-html5video/builds/209022178

Bram-Zijp commented 7 years ago

Works like a charm, thanks. Side note; I had to add these styles to get the default player playbar svg icons to display correctly (they were to small).

    ._1CiqE svg {
            width: 100%;
            height: 100%;
        }
mderrick commented 7 years ago

I wouldn't rely on those classnames as they change per build. For now, I'd add a custom className to the Video and target svgs from there.

Could you please create an issue with the the exact browser version and I will look on fixing it. Thank you!