search

mderrick / react-html5video

A customizeable HTML5 Video React component with i18n and a11y.
http://mderrick.github.io/react-html5video/
MIT License
459 stars 123 forks source link

Fix #88 PropTypes deprecation warning #92

Closed yuchuan1 closed 7 years ago

yuchuan1 commented 7 years ago

Fix #88 PropTypes deprecation warning

mderrick commented 7 years ago

Thank you! Is it possible to make prop-types a devDependency instead? This means it won't install when someone runsnpm install react-html5video. It shouldn't be needed as we only publish the build distributable. After that I think this is all good to go!

mderrick commented 7 years ago

Thanks :)

kwangkim commented 7 years ago

I do not think you update the npm library. I still see the warning.

    DefaultPlayer.propTypes = {
        copy: _react.PropTypes.object.isRequired,
        controls: _react.PropTypes.arrayOf(_react.PropTypes.oneOf(controls)),
        video: _react.PropTypes.object.isRequired
    };

Could you check the npm library? I used react-html5video 2.1.0

mderrick commented 7 years ago

Yea I've not published yet. Will do ASAP.