search

mdevilliers / SignalR.RabbitMq

MessageBus implementation using RabbitMq as the backing store.
MIT License
89 stars 40 forks source link

SignalR 3 #42

Open rmja opened 8 years ago

rmja commented 8 years ago

Any plans on supporting SignalR 3 from https://github.com/aspnet/SignalR-Server ?

mdevilliers commented 8 years ago

Hey,

The last time I looked at SignalR3 it looked like the backplane/scaleout api had remained unchanged from version 2. Admittedly this was 6 moths ago.

If this was still the case an upgrade to SignalR3 would be a case of updating the nuget package to of SignalR. Is this something you have tried?

I don't have a use case for SignalR3 at the moment but would be willing to work with someone that does.

Thanks,

Mark

rmja commented 8 years ago

@mdevilliers Perfect. I havn't tried to get it to work yet, but I will share my findings here as things progresses on my side.

rmja commented 8 years ago

I have pushed my findings here: https://github.com/rmja/SignalR.RabbitMq/tree/SignalR3 It seems to work:)

mdevilliers commented 8 years ago

Hey,

This looks awesome. Looking at your branch it seems you have spiked a solution to moving it the project to VNext as well.

Is you plan to work towards a PR?

If you were wanting to get involved I'd be happy to make you a contributor/maintainer on the project. I've recently moved jobs and don't do as much .net as I used to - it would be great to keep the project going.

Mark

rmja commented 8 years ago

Hi Mark,

Thanks, yes that is my plan, but i wanted to test it thoroughly first. I guess the pr should be to a different branch to maintain support for v2?

I know that signalr 3 is postponed until after Asp.Net Core RTM, so the code is still preliminary, but it seems to work sweet with the current bits😊

-----Oprindelig meddelelse----- Fra: "Mark deVilliers" notifications@github.com Sendt: ‎16-‎03-‎2016 20:27 Til: "mdevilliers/SignalR.RabbitMq" SignalR.RabbitMq@noreply.github.com Cc: "rmja" rmja@laesoe.org Emne: Re: [SignalR.RabbitMq] SignalR 3 (#42)

Hey, This looks awesome. Looking at your branch it seems you have spiked a solution to moving it the project to VNext as well. Is you plan to work towards a PR? If you were wanting to get involved I'd be happy to make you a contributor/maintainer on the project. I've recently moved jobs and don't do as much .net as I used to - it would be great to keep the project going. Mark — You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

mdevilliers commented 8 years ago

The v2 branch seems like a good idea - in case we needed to patch a v2 release/nuget package.

Maybe the v3 support should be on master and the nuget package gets a major version increment in line with Signalr3?