search

mdevilliers / SignalR.RabbitMq

MessageBus implementation using RabbitMq as the backing store.
MIT License
89 stars 40 forks source link

Upgrading RabbitMQ library and changing .NET framework target to 4.5.2 #49

Closed chrisdrobison closed 8 years ago

chrisdrobison commented 8 years ago

Upgrading RabbitMQ dependency. Not sure how you want to handle this as the new library required a higher .NET target. I moved it to .NET 4.5.2.

mdevilliers commented 8 years ago

Hey Chris,

Thanks for this - greatly appreciated.

It all looks good.

Can I ask the reason for the upgrade - is it bug fixes in the underlying dependencies or just a bit of house cleaning? I would rather keep the minimum dependencies up to date so it is all good.

I think we might also need some changes in the nuget file e.g. .net version, dependency versions so could you try the nuget package at https://ci.appveyor.com/project/mdevilliers/signalr-rabbitmq/build/1.0.73/artifacts and check if there are anything that needs tweaked.

Thanks again,

Mark

chrisdrobison commented 8 years ago

There are some other libraries that I use that depend on RabbitMQ that have, or will soon, update their version dependency on RabbitMQ. The library author. Has made some breaking changes in this major version change, not with your stuff, but with other aspects of the library. I've updated the Nuspec to reflect those dependency changes.

Chris On Wed, Sep 21, 2016 at 2:02 AM Mark deVilliers notifications@github.com wrote:

Hey Chris,

Thanks for this - greatly appreciated.

It all looks good.

Can I ask the reason for the upgrade - is it bug fixes in the underlying dependencies or just a bit of house cleaning? I would rather keep the minimum dependencies up to date so it is all good.

I think we might also need some changes in the nuget file e.g. .net version, dependency versions so could you try the nuget package at https://ci.appveyor.com/project/mdevilliers/signalr-rabbitmq/build/1.0.73/artifacts and check if there are anything that needs tweaked.

Thanks again,

Mark

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdevilliers/SignalR.RabbitMq/pull/49#issuecomment-248539812, or mute the thread https://github.com/notifications/unsubscribe-auth/ABu24ZTQsXko21uKyK2b0kckfDRz7a-tks5qsOR-gaJpZM4KCCmh .

mdevilliers commented 8 years ago

Awesome - I'll merge in and update the package on nuget.

Thanks for your help,

Mark

mdevilliers commented 8 years ago

The nuget package has been uploaded.