search

mdevilliers / ckeditor-nuget

Holds the scripts, nuget definition files for ckeditor
2 stars 4 forks source link

nuget package #8

Closed Eonasdan closed 7 years ago

Eonasdan commented 10 years ago

please don't just stuff everything from the repo into the nuget package. I really don't need the bower, and readme files, etc.

mdevilliers commented 10 years ago

Hey, I am going to leave the files and structure as set by the team at ckeditor. I'm basically doing this out of goodwill to them and would rather make it as simple as possible for me.

Thanks for the feedback though,

Mark

Eonasdan commented 10 years ago

I just made a grunt file for my own repo that auto builds a nuget package. Would you be interested in that?

actually it would probably be really easy to do with your build.bat file

mdevilliers commented 10 years ago

I've set it up so I just run this file

I suppose I could set up some excludes on the nuget files? Am I right in thinking its just a few of the top level files that are causing the issue? I assume they can be excluded in the nuspec file?

Eonasdan commented 10 years ago

your bat file is including all the files no matter what build, so even though you have -full, -standard, etc all the plugins get included. It would be great if you could edit the nuspec files to match the ckeditor downloads

mdevilliers commented 10 years ago

I think this is what already happens - each build (standard, standard-all etc) have a different subset of plugins - as per the ckeditor download packages.

So comparing the standard package -

ckeditor1

The differences for the standard package seem to be at the top level -

ckeditor2

The differences in this case are the bower.json and the composer.json file.

If I add an exclude for these 2 files are we good?

Eonasdan commented 10 years ago

you are correct in that the nuget package contains the right plugins, sorry. It looked like from the build script that I was just stuffing all the plugins in.

image

I would suggest the removal of these files/folders from each package. lang is optional but I feel like if someone needs the other langs they can go get them from ckeditor (but that's just me).

jquery doesn't need to be included; people needing jquery are likely going to already be using the jquery nuget package.

samples, again can be had from ckeditor if they need that otherwise it has to be deleted from every project.

the other files are github only files and are not needed for a VS project.

mdevilliers commented 10 years ago

Hey - just pushed the next version 4.4.5 and changed the nuspec files not to include the following files

ckeditor-releases\samples\. ckeditor-releases\bower.json ckeditor-releases\build-config.js ckeditor-releases\composer.json

I thought it best to keep the licence, changes and readme files.

Mark