mdeweerd / zha-toolkit

🧰 Zigbee Home Assistant Toolkit - service for "rare" Zigbee operations using ZHA on Home Assistant
GNU General Public License v3.0
198 stars 30 forks source link

Remove the toolbox icon in the ZHA Toolkit integration component name? #264

Open Hedda opened 1 month ago

Hedda commented 1 month ago

Recommend remove toolbox icon in the ZHA Toolkit integration component name as it does not follow HA's name standard. See:

🧰 icon or no 🧰 icon, that is the question?

Suggest just remove special \ud83e\uddf0 character in name "name": "ZHA \ud83e\uddf0 Toolkit", for manifest.json

{
  "domain": "zha_toolkit",
  "name": "ZHA \ud83e\uddf0 Toolkit",
  "codeowners": ["@mdeweerd"],
  "dependencies": ["zha"],
  "documentation": "https://github.com/mdeweerd/zha-toolkit",
  "iot_class": "local_polling",
  "issue_tracker": "https://github.com/mdeweerd/zha-toolkit/issues",
  "requirements": ["aiofiles>=0.4.0", "pytz>=2016.10"],
  "version": "1.0.0"
}

https://github.com/mdeweerd/zha-toolkit/blob/main/custom_components/zha_toolkit/manifest.json

Ping @alexruffell

alexruffell commented 1 month ago

@Hedda - I agree the icon should be removed. I actually always mistake it for an old music cassette... showing age here. At least it is no longer before the name where it messed with the sorting, anyhow it is now in the middle and just looks off. Doing away with it is the best option in my opinion - especially if it doesn't follow HA frontend standards.

Hedda commented 1 month ago

@mdeweerd Noted tested changing name in component manifest, wondering if changing just the same could break anything?