mdgriffith / elm-animator

A timeline-based animation engine for Elm
https://package.elm-lang.org/packages/mdgriffith/elm-animator/latest/
BSD 3-Clause "New" or "Revised" License
132 stars 15 forks source link

Add elm-review configuration #6

Closed jfmengels closed 4 years ago

jfmengels commented 4 years ago

This adds an elm-review to the project.

Since you don't have a package.json in your project, just know you should install it via npm install elm-review (globally if that's what you prefer), and then run npx elm-review or just elm-review depending on your system.

I have not fixed any of the errors, and there are quite a lot of them. I recommend that you start by commenting every rule and turn them on one by one after you fix all the errors, starting with NoUnused.Variables for instance. Also, if you don't agree with the rule or don't the value, just remove it.

Some rules (like this last one) can be autofixed. So I recommend

mdgriffith commented 4 years ago

🙌 ❤️