mdgriffith / elm-ui

What if you never had to write CSS again?
https://package.elm-lang.org/packages/mdgriffith/elm-ui/latest/
BSD 3-Clause "New" or "Revised" License
1.35k stars 110 forks source link

Regression 1.1.8 on Safari only, scrollbar does not confine element #265

Closed perty closed 3 years ago

perty commented 3 years ago

Using @alexkorban chat example on Safari stops working as intended when switching from 1.1.7 to 1.1.8.

The messages in the chat are supposed to be scrolled while the input footer remains. However, on Safari, the chat messages just overflows and pushes the footer down.

See Ellie: https://ellie-app.com/bDZPLdTmV84a1 . Unfortunately, I could not make Ellie pick another version of elm-ui than the latest.

Expected behavior The footer remains while the messages are scrolled.

Versions

alexkorban commented 3 years ago

1.1.8 requires adding height <| minimum 0 fill to the inner column to stop it overflowing. It's actually a simpler fix than in prior versions, but it's still not obvious.

perty commented 3 years ago

Thanks @alexkorban - I could never have had come up with that myself. As you say, not obvious. I mean, fill at least zero amount?

You rock, Alex.

perty commented 3 years ago

I am closing this as it apparently is fixable.