search

mdgriffith / style-elements

Create styles that don't mysteriously break!
http://package.elm-lang.org/packages/mdgriffith/style-elements/latest
BSD 3-Clause "New" or "Revised" License
445 stars 49 forks source link

Fix style variations documentation example #106

Closed CrockAgile closed 6 years ago

CrockAgile commented 6 years ago

The style variation documentation example compares variation and subtyping. However, the comparison previously confused the example use case. The mixing of "Active"/"Disabled" subtypes or the "Large" button variation caused reader confusion and compilation failure. The documentation now uses the same "Disabled" button example in both places, resolving the compilation error and reader confusion.

mdgriffith commented 6 years ago

Thanks! A previous PR I just merged caught this as well.