Closed mdhaber closed 3 months ago
I think I've responded to all comments. I've resolved some by request and where there were duplicates, typically adding a link back to one that is still open.
I'd like to resolve most of the rest because this page has gotten pretty long, so please go through and resolve the ones you agree have been addressed. If you want to click resolve but GH is not letting you, LMK that I can resolve it using a celebratory emoji (not just thumbs up or eyes, please).
The conversations I think need to be left open are:
I'd appreciate your thoughts on the first three. The last one is just a task.
@mdhaber, it's not showing me anything I can resolve, but feel free to resolve all of my comments if you can.
@tupui
rv_infrastructure
is the branch you should base your Array API work on. However, I see that there is some work inrv_continuous
that was intended to make it into SciPy already - all the stuff in_zeros.py
andtest_zeros.py
. Here's what I'd suggest:_distribution_infrastructure.py
andtest_continuous.py
fromrv_continuous
.Meanwhile, I'll submit a PR to SciPy main with the changes toDone._zeros.py
andtest_zeros.py
. Sorry those didn't make it before you reviewed the bracketing PR; apparently I had refactored for clarity in this branch.After that merges, we'll rebase this branch on SciPyDone.main
. We'll also make sure to remove the duplicate hypothesis configuration.rv_continuous
into your Array API branch again because it will have changed, but there shouldn't be any difficult merge conflicts. You should just be able to usetheirs
for all files except the ones you've modified.How does that sound?