search

mdhaber / scipy

Scipy library main repository
http://scipy.org/scipylib/
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

ENH: stats.ansari: add axis / nan_policy / keepdims support #111

Closed mdhaber closed 9 months ago

mdhaber commented 9 months ago

@tirthasheshpatel Shall I also submit a PRs that you can review, about one per week, or is that too much?

I'll wait for SciPy's CI to get fixed before opening this one on the main repo.

I think it's really as simple as this. The one thing I noticed is that currently, for Nd input, ansari returns a scalar result. However, the result seems to be garbage - it's different from axis=None / raveling the arrays before passing them to the function. So I think it's safe to let axis=0 be the default since there's no useful behavior to maintain.

tirthasheshpatel commented 9 months ago

Shall I also submit a PRs that you can review, about one per week, or is that too much?

Feel free to take some! Once per week sounds good.