search

mdhaber / scipy

Scipy library main repository
http://scipy.org/scipylib/
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

JOSS Review Suggestions #78

Closed acolum closed 2 years ago

acolum commented 2 years ago

Hi @mdhaber,

Nice work on this submission. I have a few small suggestions for improving your paper:

Under Summary:

  1. Please change "in hope of" to "in the hope of."
  2. Please change "Carefully designed tests" to "Carefully-designed tests."
  3. Please rephrase' "p-hacking", producing' to ' "p-hacking" by producing' for greater clarity.

Under Statement of need:

  1. Please change "cumulative density function (CDF)" to "cumulative distribution function (CDF)."
  2. On line 37, "cumulative distribution function" could be replaced with "CDF."

Thanks, Alyssa

For Reference: Link to Review

mdhaber commented 2 years ago

Thanks @acolum! I opened gh-79 so that the changes are easy to track.

mdhaber commented 2 years ago

Thanks again @acolum. It sounds like gh-79 addressed this, but if there were any remaining concerns, please let me know.

acolum commented 2 years ago

@mdhaber, thanks for making those changes!

Unfortunately, I noticed that one instance of "CDF" remained in the paper.md file even after the pull request was merged.

mdhaber commented 2 years ago

Oops! Fixed in d6385bcef595eadfbef815b62fe53670199f7716. (Looks like my IDE also automatically added a newline at the end of the file, but I don't think that affected the way the file renders.)

acolum commented 2 years ago

Awesome, thanks! I'll continue my review back in the original JOSS issue.