search

mdhaber / scipy

Scipy library main repository
http://scipy.org/scipylib/
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

ENH: stats: use Boost implementation of skewnorm cdf/ppf #87

Closed mdhaber closed 1 year ago

mdhaber commented 1 year ago

@mckib2 Boost's skewnorm distribution accepts location and scale. What is the best way to handle that in _info.py? a is really the third argument in Boost's implementation.

mckib2 commented 1 year ago

What is the best way to handle that in _info.py? a is really the third argument in Boost's implementation.

The codegen as is assumes (incorrectly) that the positional arguments will align from boost -> scipy. This doesn't seem like too much of an issue though, as you can simply reorder the arguments in the rv_continuous/discrete methods when they get called

mdhaber commented 1 year ago

The other arguments aren't used, so I just gave them names that never get used in the code.