Manual.py does not download subtitles when using a relative path to the file as an argument

mdhiggins / sickbeard_mp4_automator

Automatically convert video files to a standardized format with metadata tagging to create a beautiful and uniform media library

MIT License

1.51k stars 201 forks source link

Manual.py does not download subtitles when using a relative path to the file as an argument #132

Closed mstrelan closed 10 years ago

mstrelan commented 10 years ago

Relative filepath

python C:\sickbeard_mp4_automator\manual.py myfile.s04e05.mkv -silent
...
[Error 3] The system cannot find the path specified: ''
Unable to download subtitle

Absolute filepath

python C:\sickbeard_mp4_automator\manual.py E:\path\to\myfile.s04e05.mkv -silent
...
External subtitle file detected, language eng
Importing myfile.s04e05.eng.srt subtitle stream

Any ideas? I feel like I've seen this issue before but couldn't find it.

mstrelan commented 10 years ago

Also, the last debugging statement before the subtitles are downloaded is "Creating dual audio channels for iOS compatability for this stream", perhaps adding "Attempting to download subtitles" or similar would be a nice addition.

mdhiggins commented 10 years ago

Changed the inputfile to os.path.abspath(inputfile) when passing the file to subliminal, hopefully this resolves the issue.

Additionally added the suggested logging output to let the user know its attempting to download subtitles :)

6e8fe2dd7f2f7fe17bd343334cdc6fe1e12254bc

Reopen the issue if this fix doesn't work for you. Thanks.